fix(ButtonPrimitive): add missing flex-auto #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
fix/buttonprimitive-fullwidth
branch
from
9cae8ad to
911be5f
Compare
Deploying with
|
| Latest commit: |
911be5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe4592b7.orbit.pages.dev |
| Branch Preview URL: | https://fix-buttonprimitive-fullwidt.orbit.pages.dev |
DSil
approved these changes
Jan 5, 2024
| @@ -51,6 +51,23 @@ BasicButtons.story = { | |||
| }, | |||
| }; | |||
|
|
|||
| export const MultipleFullWidthButtonsInContainer = () => { | |||
There was a problem hiding this comment.
The story doesn't seem to add much documentation value to the component (and it looks quite ugly in our storybook). We should have a visual test for this.
There was a problem hiding this comment.
For sake of simplicity and fixing the bug faster I skipped visual testing here, especially that they are in Chromatic and have to rewritten to Playwright. So maybe keep that story until we will rewrite the visual tests. Wdyt? Tbh, I do not think we should care much about how it looks, if it's ugly or not, it does what it should. Another option is to remove the story, I added that to make sure that it works.
There was a problem hiding this comment.
especially that they are in Chromatic and have to rewritten to Playwright. So maybe keep that story until we will rewrite the visual tests.
Alright, agreed.
Tbh, I do not think we should care much about how it looks, if it's ugly or not, it does what it should.
Hmm a story has a purpose of documentation (especially now that we are not relying on stories for visual tests). This story tells nothing to the user. It doesn't showcase any prop or anything in particular…
So, for now, I'm ok with keeping it as is 👍
|
Size Change: +5 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here
flex: 1 1 autowas present in older version of Orbit in styled-components, got removed during Tailwind migrationStorybook: https://orbit-mainframev-fix-buttonprimitive-fullwidth.surge.sh