-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Layout): get back negative margins on Mobile in LayoutColumn #4207
Conversation
Size Change: +124 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with
|
Latest commit: |
d635927
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7943f0a3.orbit.pages.dev |
Branch Preview URL: | https://fix-layout-padding.orbit.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, but I'd rewrite the commit message to identify that the problem was specific to Card. It was introduced here, during the Card migration and the bug only affects Card. So I'd rewrite the message to something less technical and more straight to the point. Something like
fix(Layout): get back correct spacing for Card on Mobile
Just a suggestion, and non-blocking
f367f22
to
d635927
Compare
We used to have negative margins in the first Card inside LayoutColumn, it was applied for Mobile, to remove the Card padding and have content "full-width" on Mobile, without paddings on the sides. I guess it was an accidental breaking change and better will be to get it back, maybe it was removed during the Card migration to TW
The Slack-related thread
Storybook: https://orbit-mainframev-fix-layout-padding.surge.sh