-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tailwind): remove uneccesseary folder nesting #4201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -4 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying with
|
Latest commit: |
ab5bfd8
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d5765d8c.orbit.pages.dev |
Branch Preview URL: | https://chore-refactor-tailwind-pres.orbit.pages.dev |
ac8ec3d
to
17f0d3b
Compare
17f0d3b
to
da0cdb2
Compare
da0cdb2
to
ab5bfd8
Compare
DSil
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary folder nesting and made the package structure more flat. It's less messy now and will be better to have it like that for further maintenance. Not urgent for review, PR isn't introducing anything new, simply moving the things out of folders 1 level higher in tree
I know that there might be different opinions on folders like
utils
, even when I think in certain cases it's ok to have it, I couldn't find a better name for shared utility functions, maybe we can name ittext
as it contains lodash-like helper functions working with strings or we can also have them on the root level without specific folder.Storybook: https://orbit-mainframev-chore-refactor-tailwind-preset.surge.sh