feat(Popover): migrate to Tailwind #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4dcbbe4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e879565.orbit.pages.dev |
| Branch Preview URL: | https://tw-popover.orbit.pages.dev |
|
Size Change: -173 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
mainframev
force-pushed
the
tw/popover
branch
from
863109e to
f59ea07
Compare
DSil
requested changes
Nov 15, 2023
packages/orbit-components/src/Popover/components/ContentWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Popover/components/ContentWrapper.tsx
Outdated
Show resolved
Hide resolved
| onClick={onClose} | ||
| /> | ||
| <div | ||
| role="tooltip" |
There was a problem hiding this comment.
The definition of this role is
A tooltip is a contextual text bubble that displays a description for an element that appears on pointer hover or keyboard focus.
And this is not true for a Popover, which does not open on pointer hover nor keyboard focus.
There was a problem hiding this comment.
I did not add this, it was like that before
There was a problem hiding this comment.
I found this info useful, maybe will apply something different then
packages/orbit-components/src/Popover/components/ContentWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Popover/components/ContentWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Popover/components/ContentWrapper.tsx
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
tw/popover
branch
from
f59ea07 to
3a34785
Compare
mainframev
force-pushed
the
tw/popover
branch
2 times, most recently
from
b837bb4 to
8c4105e
Compare
DSil
reviewed
Nov 20, 2023
DSil
reviewed
Nov 20, 2023
| style={ | ||
| { | ||
| "--actions-height": actionsHeight != null && `${actionsHeight}px`, | ||
| "--windowHeight": windowHeight != null && `${windowHeight}px`, |
There was a problem hiding this comment.
Suggested change
| "--windowHeight": windowHeight != null && `${windowHeight}px`, | |
| "--window-height": windowHeight != null && `${windowHeight}px`, |
|
I just noticed that the problem reported on the first review is also not fixed, so please address that as well |
mainframev
force-pushed
the
tw/popover
branch
from
8c4105e to
933ea48
Compare
DSil
approved these changes
Nov 21, 2023
test(Popover): add linux screenshots
mainframev
force-pushed
the
tw/popover
branch
from
933ea48 to
4dcbbe4
Compare
RobinCsl
reviewed
Nov 24, 2023
| @@ -39,6 +34,7 @@ const Popover = ({ | |||
| dataTest, | |||
| }: Props) => { | |||
| const ref = React.useRef<HTMLDivElement | null>(null); | |||
| const popoverId = React.useId(); | |||
There was a problem hiding this comment.
We should be careful with these in code reviews as we still need to use useId from our provider, not from React directly as some folks haven't migrated to React 18 yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
Giving solution to FEPLT-1768
For tailwind migrations:
tailwind-migration-status.yamlfile has been updated with the migrated component(s).Storybook: https://orbit-mainframev-tw-popover.surge.sh