Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update orientation.py #600

Closed
wants to merge 1 commit into from
Closed

Update orientation.py #600

wants to merge 1 commit into from

Conversation

Sahil-pixel
Copy link

if mode == 'any':
activity.setRequestedOrientation(
ActivityInfo.SCREEN_ORIENTATION_USER)

SCREEN_ORIENTATION_USER is which user can set portrait or auto rotate via Android Quick menu panel

@Sahil-pixel
Update orientation.py
68d8b72 
SCREEN_ORIENTATION_USER is User mode which user can set
@akshayaurora akshayaurora self-requested a review June 2, 2021 12:34
akshayaurora
akshayaurora requested changes Jun 2, 2021
View reviewed changes
Copy link
Member

@akshayaurora akshayaurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, it makes sense to add this as a additional option, mode = 'user'?

@akshayaurora
Copy link
Member

Closing in favour of #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayaurora akshayaurora akshayaurora requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sahil-pixel @akshayaurora