Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "path must include project and resource name" in Eclipse #6366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthias-ronge
Copy link
Collaborator

Eclipse is unwilling to resolve the directory '../config-local' because it is located outside the module's sub-folder. Using the Maven variable instead fixes it.

Eclipse is unwilling to resolve the  directory '../config-local' because
it is located outside the module's sub-folder. Using the Maven variable
instead fixes it.
@solth
Copy link
Member

solth commented Jan 21, 2025

I read through a long thread discussing the multiModuleProjectDirectory property (see apache/maven#840 and apache/maven#1061).

It seems the property maven.multiModuleProjectDirectory is only meant for internal purpose and not intended to be used in other projects. It seems Maven 4 will contain a new property that should be used instead, but for now I can live with using multiModuleProjectDirectory if that resolves the IDE problems for you, @matthias-ronge
I tested the change locally and Kitodo compiles and runs correctly on my system as well. I would perhaps prefer that you add a comment to the variable pointing to the discussion mentioned above, though.

Before merging this pull request I would also like to know if it works in other environments as well. (@henning-gerhardt & @stweil , any thoughts about this?)

@henning-gerhardt
Copy link
Collaborator

henning-gerhardt commented Jan 22, 2025

The change did not introduce a regression in my usage scenarios: building the application (development and non-development version) on console with mvn and executing the application (development version) inside the IDE.

Like @solth already mentioned: on both places should be added a hint that this solution is maybe only working with Maven 3.x and may not work with Maven 4.x. Maybe the hint should even include a link to this issue / pull request so it is understandable in the future why this change was made in the past and which possible solutions may exists if there is any problem with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants