Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add missing label for tx_dlf_tokens #1482

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

stweil
Copy link
Member

@stweil stweil commented Feb 8, 2025

This fixes the currently empty record name when a new Kitodo.Presentation record is added in the TYPO3 backend.

@stweil stweil self-assigned this Feb 8, 2025
This fixes the currently empty record name when a new Kitodo.Presentation
record is added in the TYPO3 backend.

Signed-off-by: Stefan Weil <[email protected]>
@stweil stweil changed the title [BUGFIX] Add missing label for tx_dlf_token [BUGFIX] Add missing label for tx_dlf_tokens Feb 8, 2025
@stweil
Copy link
Member Author

stweil commented Feb 8, 2025

See related discussion #1469.

@sebastian-meyer sebastian-meyer self-requested a review February 10, 2025 11:02
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9cc612a) to head (f76f51a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1482   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-meyer
Copy link
Member

This is fine for now, but ultimately we should not display those records in the backend at all.

@sebastian-meyer sebastian-meyer merged commit 45a8769 into kitodo:main Feb 10, 2025
8 checks passed
@stweil stweil deleted the tx_dlf_tokens branch February 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants