Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Drop support for PHP 7.4 and 8.0 #1458

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

stweil
Copy link
Member

@stweil stweil commented Feb 2, 2025

Both PHP releases had their end of life long ago.

Both PHP releases had their end of life long ago.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Member Author

stweil commented Feb 2, 2025

The CI list above says "TYPO3 (11.5, 7.4) Expected — Waiting for status to be reported". Where does this come from?

@sebastian-meyer sebastian-meyer self-requested a review February 3, 2025 09:59
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Feb 3, 2025
@sebastian-meyer sebastian-meyer changed the title Drop support for PHP 7.4 and 8.0 [MAINTENANCE] Drop support for PHP 7.4 and 8.0 Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (90e66f5) to head (245817f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1458   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-meyer
Copy link
Member

The CI list above says "TYPO3 (11.5, 7.4) Expected — Waiting for status to be reported". Where does this come from?

That's because I've marked those tests as mandatory. I'll fix this after merging.

@sebastian-meyer sebastian-meyer merged commit ea4b14f into kitodo:main Feb 3, 2025
10 checks passed
@stweil stweil deleted the drop_old_php branch February 5, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants