Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Clarifiy unexpected Packet private CIDR behaviour #163

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

DGollings
Copy link
Contributor

Attempts to address or at least mitigate issue #159

Attempts to address or at least mitigate issue kinvolk-archives#159
@DGollings DGollings requested a review from rata February 5, 2020 16:11
Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR title to be more representative of what the change does? :)

@DGollings DGollings changed the title Update packet.md Clarifiy unexpected Packet private CIDR behaviour Feb 5, 2020
Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the commit titles to reflect the changes, (not just the unsuful gihub default of "Update ", squash them if possible :)

@DGollings
Copy link
Contributor Author

Also, please update the commit titles to reflect the changes, (not just the unsuful gihub default of "Update ", squash them if possible :)

I'm more of a 'never rewrite (git) history' type of guy, so never bothered to learn how to either rename a commit or squash it, could you point me to the FM and I'll figure it out :)

@rata
Copy link
Contributor

rata commented Feb 5, 2020

@DGollings no worries, just add a different commit then and I can squash on merge :)

@DGollings
Copy link
Contributor Author

DGollings commented Feb 5, 2020

Quite the discussion: https://softwareengineering.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests

I can see the pro/cons, but trunk based development ftw (?)

done, ish, removed what I think was a duplicate Note:
(edit: although I agree my original commit message was useless)

Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again! :-)

@rata rata merged commit 2391fde into kinvolk-archives:master Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants