-
Notifications
You must be signed in to change notification settings - Fork 19
Clarifiy unexpected Packet private CIDR behaviour #163
Conversation
Attempts to address or at least mitigate issue kinvolk-archives#159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the PR title to be more representative of what the change does? :)
Co-Authored-By: rata <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please update the commit titles to reflect the changes, (not just the unsuful gihub default of "Update ", squash them if possible :)
I'm more of a 'never rewrite (git) history' type of guy, so never bothered to learn how to either rename a commit or squash it, could you point me to the FM and I'll figure it out :) |
@DGollings no worries, just add a different commit then and I can squash on merge :) |
Quite the discussion: https://softwareengineering.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests I can see the pro/cons, but trunk based development ftw (?) done, ish, removed what I think was a duplicate Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again! :-)
Attempts to address or at least mitigate issue #159