Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x][incubator-kie-issues-1105] Polymorphic json typing causes long delays in first request (#3046) #3071

Open
wants to merge 1 commit into
base: 7.67.x
Choose a base branch
from

Conversation

gmunozfe
Copy link
Member

Backported from #3046

Thank you for submitting this pull request

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gmunozfe gmunozfe requested a review from fjtirado January 16, 2025 14:56
@gmunozfe
Copy link
Member Author

@danielemams you can also review

@gmunozfe
Copy link
Member Author

jenkins do fdb

@danielemams
Copy link

danielemams commented Jan 17, 2025

Hi,
from my checks, this commit is correct and contains the correct code that has to be backported on 7.67.x branch.
To be more clear, this commit contains commit 1829d1e cherry-picked on 7.67.x branch.
There was only one conflict on: org/kie/server/api/marshalling/json/JSONMarshaller.java and it was correctly solved accepted version that was already present on 7.67.x branch, not the version that cames from the cherry-picked commit.
Thank you,
Daniele Mammarella

@mareknovotny
Copy link
Member

jenkins retest this please

@mareknovotny
Copy link
Member

jenkins do fdb

@gmunozfe
Copy link
Member Author

gmunozfe commented Feb 5, 2025

jenkins retest this

@gmunozfe
Copy link
Member Author

gmunozfe commented Feb 5, 2025

jenkins do fdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants