Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 update reference names and links #141

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

dmiller15
Copy link
Contributor

Description

Closes https://d3b.atlassian.net/browse/BIXU-3687

Type of change

  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Just docs

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added bug Something isn't working documentation Adds documentation bix-dev This issue or pull request is bix-dev work labels Jun 17, 2024
@dmiller15 dmiller15 self-assigned this Jun 17, 2024
Copy link
Member

@yuankunzhu yuankunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we confirmed that the new broad google bucket points to the same files that we use?

@dmiller15
Copy link
Contributor Author

@yuankunzhu Yes. All the references for the alignment workflow that we pull from broad are in that bucket

@dmiller15 dmiller15 marked this pull request as ready for review June 17, 2024 14:56
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dmiller15 dmiller15 merged commit f08577f into master Jun 17, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-update-broad-gcp-links branch June 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working documentation Adds documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants