Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Kiali-1814 Revert typescript and react-script-ts upgrade #766

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

vnugent
Copy link
Contributor

@vnugent vnugent commented Oct 23, 2018

** Describe the change **

** Issue reference **
KIALI-1814
** Backwards compatible? **
Yes

@@ -124,6 +124,9 @@
"tslint-no-circular-imports": "0.5.0",
"typescript": "3.1.3"
},
"resolutions": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to prevent yarn from pulling in multiple versions of @types/react

@rhqci
Copy link

rhqci commented Oct 23, 2018

✔️ Jenkins CI: kiali-ui-pr-e2e-test #259

KIALI_NAME=kialiuipr766-istio-system

Copy link
Contributor

@mtho11 mtho11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tests pass.

@mtho11 mtho11 merged commit 379805b into kiali:master Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants