-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms signup improvements 1 #244
Open
hydra
wants to merge
10
commits into
khonsulabs:main
Choose a base branch
from
hydra:forms-signup-improvements-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
53e4281
Fix 'Signing-up' modal casing and hyphenation.
hydra 807ada1
Fix comment spelling errors.
hydra 8fdad78
Move the form fields into a struct.
hydra 8cc71c1
Clarify request building by using a named variable called `request`.
hydra 886e4bf
Refactor `signup_form` into a `build` method on a `SignupForm` implem…
hydra 91b6c42
Introduce `LoginArgs` instead of passing username and password around…
hydra 9208585
Avoid coupling of the form fields to the API. Make the API more real…
hydra 04eef7f
Add some more basic arbitrary API rules.
hydra 6f5654d
Add `force_set` to the Value API.
hydra 4a05ed1
Use `force_set` instead of `set` to ensure subscribers to the api_err…
hydra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies should not be added specifically for examples.