Fix Chat Streaming on Obsidian, Docker Image Version and First-Run, Chat Error Messages in Clients #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable chat input field if getChatHistory had error as Khoj may not be setup correctly to chat
- Convert renderIncrementalMessage to an async method as MarkdownRenderer is an async method - Simplify code, remove unneeded JSON check
sabaimran
reviewed
Dec 21, 2023
sabaimran
reviewed
Dec 21, 2023
sabaimran
reviewed
Dec 21, 2023
sabaimran
reviewed
Dec 21, 2023
debanjum
force-pushed
the
fix-client-streaming-and-indexing
branch
from
8af1270 to
4bdcec8
Compare
sabaimran
reviewed
Dec 22, 2023
debanjum
force-pushed
the
fix-client-streaming-and-indexing
branch
from
b67cb44 to
a0997b2
Compare
This will allow troubleshooting by getting the actual khoj version being used. Previously it was always set to a static 0.0.0 version Command to build Khoj docker image with dynamically set current app version: `docker-compose build server --build-arg VERSION=$(pipx run hatch version)'
debanjum
force-pushed
the
fix-client-streaming-and-indexing
branch
from
a0997b2 to
95880fe
Compare
- Tag docker image with `tag_name' on release (i.e tag push) - Else tag with 'pre' on push to master - Else tag with 'dev' on push to PR branch - Only tag the latest release with release tag Previously the latest commit on master was being tagged with the latest tag. This doesn't sync with the release cadence of the rest of Khoj
debanjum
force-pushed
the
fix-client-streaming-and-indexing
branch
from
95880fe to
6ae6988
Compare
- Delete unused config directory
debanjum
force-pushed
the
fix-client-streaming-and-indexing
branch
from
6ae6988 to
074123b
Compare
debanjum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latesttagThis align docker image release cadence with client, server releases