feat(linux): add --remote-debug flag to run-tests.sh script 🕷️
#13233
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
requested review from
darcywong00,
mcdurdin and
jahorton
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
darcywong00
requested changes
Feb 14, 2025
| get_caps_lock_state(IBusKeymanTestsFixture *fixture) { | ||
| return get_capslock_indicator(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Also some cleanup.
Sorry to ask for extra work. Could we split this to a separate PR, so this PR only has --remote-debug changes?
darcywong00
reviewed
Feb 14, 2025
| @@ -36,6 +37,7 @@ function help() { | |||
| echo " --help, -h, -? Display this help" | |||
| echo " --verbose, -v Run tests verbosely" | |||
| echo " --debug debug test logging output" | |||
| echo " --remote-debug start gdbserver after setup but prior to running the tests" | |||
There was a problem hiding this comment.
Can --debug and --remote-debug be used at the same time?
There was a problem hiding this comment.
Yes. --remote-debug allows to attach a debugger, --debug outputs more log messages.
ermshiperete
force-pushed
the
chore/linux/improve-tests
branch
2 times, most recently
from
c60e1f6 to
1621685
Compare
This allows to run the tests in a VM and debug them remotely. Co-authored-by: Darcy Wong <[email protected]>
ermshiperete
force-pushed
the
chore/linux/improve-tests
branch
from
1621685 to
051e6c7
Compare
ermshiperete
changed the title
--remote-debug flag to run-tests.sh script --remote-debug flag to run-tests.sh script 🕷️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to run the tests in a VM and debug them remotely. Also document debugging the integration tests, and improve the output if dependencies are missing.
Also some cleanup.
@keymanapp-test-bot skip