change(web): drop 'dom' unit test concurrency when run in CI mode

[jahorton]

@keymanapp-test-bot skip

[keymanapp-test-bot]

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

• Android
  • Keyman for Android apk
  • FirstVoices for Android 16.0 apk
  • FirstVoices Keyboards for Android apk
  • KeyboardHarness apk
  • Keyman for Android 16.0 apk
  • KMSample1 apk
  • KMSample2 apk
• Developer
  • Keyman Developer
  • Compiler Regression Tests
  • kmcomp.zip
• iOS
  • Keyman for iOS (simulator image)
  • FirstVoices Keyboards for iOS (simulator image)
  • TestFlight internal PR build version - 18.0.186 (0.13141.12802)
• Keyboards
  • Test Keyboards
• Web
  • KeymanWeb Test Home
• Windows
  • Keyman for Windows
  • FirstVoices Keyboards for Windows
  • Text Editor (32 bit)
  • Text Editor (64 bit)

[jahorton]

I just noticed that this setting was missing from the 'dom' subfolder while present in the 'integrated' subfolder. There's no clear cause behind the difference in state when tracing the origin of the lines via git blame. Concurrency is known to reduce stability a bit, so perhaps dropping it in CI mode may help with #12638.

keyman/web/src/test/auto/integrated/web-test-runner.CI.config.mjs

Line 9 in bbd1dd8

concurrency: 1,

[jahorton]

Solid run on ba-win10-64-key-01: https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/522529.
Success with ba-win10-64-key-02: https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/522530.
And a solid set for ba-win10-64-s1-601 as well: https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/522532

With ba-win10-64-pp-602, we have a few tests missing... and I haven't found anything clear in the logs quite yet. Will need to inspect more thoroughly: https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/522531.

• Surprisingly few are missing, so you'd think it would have to be near the run's end... but I don't see relevant log messages there.
• The only distinct thing I've seen so far:

  [15:55:52] :	 [Step 2/6] [web/src/engine/predictive-text/worker-main/unit_tests] ## test:headless completed successfully
  [15:55:56]W:	 [Step 2/6] parse error: Invalid numeric literal at line 1, column 10
  [15:55:56]W:	 [Step 2/6] parse error: Invalid numeric literal at line 1, column 10
  [15:55:56] :	 [Step 2/6] Auto-skipping <test:browser> for unrelated CI test build
  

  Those "parse error" lines do not appear in the test runs that reached the full test count.

[jahorton]

Wait a second...

15:55:56   Auto-skipping <test:browser> for unrelated CI test build

It's not skipped by the one with the full test count.

Also, on further inspection... test:libraries is being run; I thought that was supposed to be turned off for the main Web build. That'd have been part of #12866.

keyman/web/build.sh

Line 38 in 02ad043

":engine/predictive-text=src/engine/predictive-text/worker-main Builds KMW's predictive text module" \

Ah, missed that - it's been bypassing #12866's script, and thus the predictive-text test filtering. Doesn't entirely explain by test-browser got skipped, admittedly.

That corresponds to these lines:

keyman/web/src/engine/predictive-text/worker-main/unit_tests/test.sh

Lines 81 to 96 in 02ad043

	# If we are running a TeamCity test build, for now, only run BrowserStack
	# tests when on a PR branch with a title including "(web)" or with the label
	# test-browserstack. This is because the BrowserStack tests are currently
	# unreliable, and the false positive failures are masking actual failures.
	#
	# We do not run BrowserStack tests on master, beta, or stable-x.y test
	# builds.
	if [[ $VERSION_ENVIRONMENT == test ]] && builder_has_action test:browser; then
	if builder_pull_get_details; then
	if ! ([[ $builder_pull_title =~ \(web\) ]] || builder_pull_has_label test-browserstack); then
	echo "Auto-skipping $(builder_term test:browser) for unrelated CI test build"
	exit 0
	fi
	fi
	fi

But change(web) is part of this PR's title. Shouldn't that have prevented the 'skip'?

[keyman-server]

Changes in this pull request will be available for download in Keyman version 18.0.193-beta