fix(web): disabled autoaccept should not autohighlight suggestions #13068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts
|
jahorton
commented
Jan 29, 2025
Comment on lines
+752
to
+754
| if(this.predictionContext.selected == suggestion) { | ||
| d.highlight(true); | ||
| } |
There was a problem hiding this comment.
If we instead replace the if-condition with suggestion?.autoHighlight, we can keep the "autocorrect hint" around in a cleaner way. Any interaction with the banner would instantly (and permanently) deselect it this way.
Test ResultsI tested this issue with the attached "Keyman-18.0.180-alpha-test-13068" build(29/01/2025) on Android 14(physical device). Here I am sharing my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
ermshiperete
approved these changes
Jan 29, 2025
|
Changes in this pull request will be available for download in Keyman version 18.0.181-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written this PR in such a way that it should be fully compatible with #12893 when merged in.
There was no pre-existing issue for it, but I just realized that we still had a tiny bit of active autocorrect behavior enabled on
master- the suggestion we would autocorrect to was being highlighted. It wouldn't trigger, but it could lead to "fun" cases where that suggestion and a touched suggestion would both be highlighted at the same time.Part of me... actually kind of liked having the autocorrect "hint" active, but this was definitely not intended.
User Testing
TEST_ANDROID_AUTOHIGHLIGHT: Using Keyman for Android and
sil_euro_latinset to English, typetrouband verify thattroubleis not automatically highlighted.