Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for pandora PFA #419

Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9259e7c
add detector type, calodata, muon tagger with phi-theta segmentation …
giovannimarchiori Jan 15, 2025
a9c89b8
move to phi-theta grid for muon tagger and use volume compatible with…
giovannimarchiori Jan 15, 2025
7a4153d
add extent info to ecal endcap turbine class
giovannimarchiori Jan 20, 2025
60a2e95
fix typo
giovannimarchiori Jan 23, 2025
f7294b1
fix bug with endcap building
giovannimarchiori Jan 27, 2025
bc87e12
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Jan 27, 2025
922e4ce
introduce separate readouts for muon barrel and endcap
giovannimarchiori Jan 27, 2025
e8b4d82
remove commented code
giovannimarchiori Jan 27, 2025
1cef8c7
fix xml
giovannimarchiori Jan 27, 2025
a8b9b09
use same muon detector for ALLEGRO v03 and v04
giovannimarchiori Jan 28, 2025
689a685
try to add segmentation to simple cylinder
giovannimarchiori Jan 29, 2025
1b4ef34
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Jan 30, 2025
55da3a9
improve simple cylinder code
giovannimarchiori Jan 31, 2025
3aa5b60
add possibility of having layers in simple cylinder volume
giovannimarchiori Jan 31, 2025
2651b42
set inner and outer radiation and interaction lenghts otherwise pando…
giovannimarchiori Feb 3, 2025
8d93453
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Feb 5, 2025
0cf332b
indentation and add one comment
giovannimarchiori Feb 10, 2025
2050a2a
modify type of sensitive detector for muon tagger for pandora
giovannimarchiori Feb 10, 2025
8682e71
Merge branch 'key4hep:main' into gmarchio-main-pandora-20250114
giovannimarchiori Feb 10, 2025
f68a0d2
implement comments by Alvaro
giovannimarchiori Feb 11, 2025
6300299
fix calculation of radiation and interaction lenghts (missing scale f…
giovannimarchiori Feb 11, 2025
b56cc5b
comment the code
giovannimarchiori Feb 11, 2025
c6aec39
fix comment
giovannimarchiori Feb 11, 2025
8c5bc80
fix comment
giovannimarchiori Feb 11, 2025
31c0393
merge simple cylinder v02 and v03
giovannimarchiori Feb 11, 2025
58e9f9a
update readme
giovannimarchiori Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move to phi-theta grid for muon tagger and use volume compatible with…
… pandora
giovannimarchiori committed Jan 15, 2025
commit a9c89b89878d7f1fc9cfa9855e8c2f441c750679
2 changes: 1 addition & 1 deletion FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/ALLEGRO_o1_v03.xml
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@
<include ref="HCalBarrel_TileCal_v03.xml"/>
<include ref="ECalEndcaps_Turbine.xml"/>
<include ref="HCalEndcaps_ThreeParts_TileCal_v03.xml"/>
<include ref="MuonTagger.xml"/>
<include ref="MuonTaggerPhiTheta.xml"/>

<fields>
<!-- FIXME this is a place holder to get a reasonable magnetic field, it should be a real MAP obtained from FEM tools taking into account HCAL return yoke -->
50 changes: 50 additions & 0 deletions FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/MuonTaggerPhiTheta.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?xml version="1.0" encoding="UTF-8"?>
<lccdd xmlns:compact="http://www.lcsim.org/schemas/compact/1.0"
xmlns:xs="http://www.w3.org/2001/XMLSchema"
xs:noNamespaceSchemaLocation="http://www.lcsim.org/schemas/compact/1.0/compact.xsd">

<info name="FCCeeMuonTagger"
title="Muon Tagger for ALLEGRO, with phi-theta segmentation"
author="Created by A. Duglishvili from MuonTagger.xml, moving from eta to theta segmentation"
url="no"
status="development"
version="1.0">
<comment>
Simple muon tagger with phi-theta segmentation - barrel and endcaps
</comment>
</info>

<display>
<vis name="muon_vis" r="1.0" g="0.1" b="0.1" showDaughters="true" visible="true" />
</display>

<readouts>
<readout name="MuonTaggerPhiTheta">
<segmentation type="FCCSWGridPhiTheta_k4geo" phi_bins="704" offset_phi="-pi+(pi/704.)" grid_size_theta="0.010013373" offset_theta="0.10884388"/>
<id>system:4,subsystem:1,layer:5,theta:10,phi:10</id>
</readout>
</readouts>

<detectors>
<!-- positive side: cryostat -->
<detector id="DetID_Muon_Barrel" name="MuonTaggerBarrel" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerPhiTheta">
<!-- added for Pandora -->
<type_flags type="DetType_CALORIMETER + DetType_MUON + DetType_BARREL"/>
<!-- end -->
<sensitive type="SimpleTrackerSD"/>
<dimensions rmin="MuonTagger_inner_radius" rmax="MuonTagger_outer_radius"
dz="MuonTagger_half_length" z_offset = "0" material="Polystyrene" phi0="0" deltaphi="360*deg" vis="muon_vis"/>
</detector>

<detector id="DetID_Muon_Endcap_1" name="MuonTaggerEndcap_positive" type="SimpleCylinder_o1_v02" sensitive="true" vis="muon_vis" readout="MuonTaggerPhiTheta">
<!-- added for Pandora -->
<type_flags type="DetType_CALORIMETER + DetType_MUON + DetType_ENDCAP"/>
<!-- end -->
<sensitive type="SimpleTrackerSD"/>
<dimensions rmin="MuonTaggerEndcap_inner_radius" rmax="MuonTaggerEndcap_outer_radius"
dz="(MuonTaggerEndcap_max_z - MuonTaggerEndcap_min_z)*0.5" z_offset = "MuonTaggerEndcap_min_z + (MuonTaggerEndcap_max_z - MuonTaggerEndcap_min_z)*0.5" material="Polystyrene" phi0="0" deltaphi="360*deg" vis="muon_vis"/>
</detector>

</detectors>

</lccdd>