Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version of the detailed description of the IDEA drift chamber #307

Merged
merged 21 commits into from
Dec 14, 2023
Merged

First version of the detailed description of the IDEA drift chamber #307

merged 21 commits into from
Dec 14, 2023

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Dec 6, 2023 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • Added DriftChamber_o1_v01, a first version of the detailed IDEA drift chamber to enable further technical developments (digitization, tracking, PFlow, ...)

ENDRELEASENOTES

Covered by test_IDEA_o1_v02.

Look at detector/tracker/README.md to see what should be further improved.

BrieucF added 14 commits December 6, 2023 12:55
@andresailer andresailer changed the title Frist version of the detailed description of the IDEA drift chamber First version of the detailed description of the IDEA drift chamber Dec 6, 2023
@BrieucF
Copy link
Contributor Author

BrieucF commented Dec 7, 2023

The tests are passing now, ready for review

@BrieucF
Copy link
Contributor Author

BrieucF commented Dec 11, 2023

Thanks Juan!

@BrieucF
Copy link
Contributor Author

BrieucF commented Dec 14, 2023

Can we merge this?

@andresailer andresailer merged commit ebd1978 into key4hep:main Dec 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcarcell jmcarcell jmcarcell left review comments

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrieucF @andresailer @jmcarcell