Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IDEA dual-readout calorimeter geometry #292

Closed
wants to merge 25 commits into from
+3,718 −82
Closed

Migrate IDEA dual-readout calorimeter geometry #292

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f45e63c
with latest dual-readout (2023-09-21) pacakge, migrated DRC geometry …
swkim95 Sep 21, 2023
bd28ad7
Remove cout used for debugging
swkim95 Sep 25, 2023
5c9075a
DRC migration code update with latest dual-readout and k4geo package …
swkim95 Dec 7, 2023
4c8a5be
Merge branch 'DRC_geo_migrate_230918' into DRC_geo_migrate_231113
swkim95 Dec 7, 2023
5280557
Merge pull request #1 from swkim95/DRC_geo_migrate_231113
swkim95 Dec 7, 2023
ccabc2f
remove cout for the debug
swkim95 Dec 7, 2023
9d25eb5
Remove duplicated DRC compact file & source codes under IDEA directory
swkim95 Dec 7, 2023
4ea51dc
Update DRC detetor builder to latest version
swkim95 Dec 7, 2023
4ebaae3
Merge branch 'main' into DRC_geo_migrate_230918
swkim95 Dec 19, 2023
b0bfcf9
Merge branch 'key4hep:main' into DRC_geo_migrate_230918
swkim95 Jan 18, 2024
0a96366
Update branch with latest k4geo & Split FiberDRC xml files
swkim95 Mar 7, 2024
df5d782
remove debugging cout
swkim95 Mar 7, 2024
d09dc81
Merge branch 'DRC_geo_migrate_230918' into PRupdate
swkim95 Mar 7, 2024
369d1ec
Merge pull request #2 from swkim95/PRupdate
swkim95 Mar 7, 2024
ccd166e
Remove unused xml files, remove IDEA directory (which does not exists…
swkim95 Mar 7, 2024
86941a0
Updates in IDEA XML files for implemeting Dual-readout calorimeter, D…
swkim95 Apr 23, 2024
ccd8dfc
Merge branch 'DRC_geo_migrate_230918' into PRupdate_240408
swkim95 Apr 23, 2024
ad54c67
Merge pull request #3 from swkim95/PRupdate_240408
swkim95 Apr 23, 2024
2c222d2
Fix xml files (remove redundant includes, remove DRC material propert…
swkim95 Apr 30, 2024
f5ed2f2
Update branch to latest k4geo master branch
swkim95 Jun 1, 2024
09107f1
Fix units in SD action plugin, add wavelength information in output file
swkim95 Jun 1, 2024
dccbd0a
Add Fiber DRC xml to IDEA v03
swkim95 Jun 1, 2024
9674154
remove debugging message, find EDM4HEP for plugins
swkim95 Jun 1, 2024
806a6af
Remove DRC from IDEA v02
swkim95 Jun 5, 2024
1a6c652
Fix indentation
swkim95 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused xml files, remove IDEA directory (which does not exists… 
…) in CMakeList compact file installation part
@swkim95
swkim95 committed Mar 7, 2024
commit ccd166eabc7e3afc757611d15efc8df8eefd7f10
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -154,7 +154,7 @@ INSTALL(FILES ${hfiles}

#--- install compact files------------------------------
if(INSTALL_COMPACT_FILES)
INSTALL(DIRECTORY CaloTB CLIC FCalTB FCCee ILD fieldmaps SiD IDEA DESTINATION share/k4geo )
INSTALL(DIRECTORY CaloTB CLIC FCalTB FCCee ILD fieldmaps SiD DESTINATION share/k4geo )
endif()

# create k4geoConfig and friends
745 changes: 0 additions & 745 deletions FCCee/IDEA/compact/IDEA_o1_v02/DRcalo.xml
View file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to keep one file for the detector description (see the other comment on FCCee/IDEA/compact/IDEA_o1_v02/DRcalo_Wratten9_S13615-1025.xml)

This file was deleted.

729 changes: 0 additions & 729 deletions FCCee/IDEA/compact/IDEA_o1_v02/DRcalo_IDEA.xml
View file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed and the detector should be integrated to FCCee/IDEA/compact/IDEA_o1_v02/IDEA_o1_v02.xml. Can you also make sure that the dimensions are compatible with the one here: https://fcc-ee-detector-full-sim.docs.cern.ch/IDEA/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is compatible but not 100% sure...
I'll ask Sanghyun about it.

About various DRcalo xml files, I'm also not sure which one to use.
I'll also discuss this with Sanghyun and fix which xml file to include.

This file was deleted.

740 changes: 0 additions & 740 deletions FCCee/IDEA/compact/IDEA_o1_v02/DRcalo_Wratten9_S13615-1025.xml
View file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be split:

  • global "envelope parameters" should go to FCCee/IDEA/compact/IDEA_o1_v02/DectDimensions_IDEA_o1_v01.xml (please profit from this occasion to remove all the other ECAL/HCAL dimensions which will no longer be used in this file)
  • detector specific parameters should go to a dedicated file that I propose to name FCCee/IDEA/compact/IDEA_o1_v02/FiberDualReadoutCalo_o1_v01.xml
  • missing materials/elements should go to FCCee/IDEA/compact/IDEA_o1_v02/elements_o1_v01.xml and FCCee/IDEA/compact/IDEA_o1_v02/materials_o1_v01.xml

This file was deleted.