Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add an OutputLevel if Verbosity is set #205

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Dec 6, 2024

Unlike Marlin, Gaudi doesn't override OutputLevels of Algorithms if they have been manually set in the options file. Hence, if we populate all wrapped processor OutputLevels it will require changing all of them manually afterwards if we want the global OutputLevel that is set in the AlgorithmMgr to apply.

BEGINRELEASENOTES

  • Only set the OutputLevel for converted MarlinProcessors if Verbosity was set in the original XML steering file

ENDRELEASENOTES

Unlike Marlin Gaudi doesn't override OutputLevels of Algorithms if they
have been manually set in the options file. Hence, if we populate all
wrapped processor OutputLevels it will require changing all of them
manually afterwards if we want the global OutputLevel that is set in the
AlgorithmMgr to apply.
Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense and will make it easier for the verbosity to be controlled from Gaudi.

@jmcarcell jmcarcell merged commit c1227e9 into main Dec 9, 2024
11 checks passed
@jmcarcell jmcarcell deleted the convert-no-default-output-level branch December 9, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants