Add the edm4hep includes to allow compilation with clang #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Jan 27, 2024
|
Yeah I think it's because of the pointers. I removed some includes, I'm not sure if I got them all |
jmcarcell
added a commit
that referenced
this pull request
Jan 29, 2024
…es to allow compilation with clang (#166)
jmcarcell
added a commit
that referenced
this pull request
Feb 5, 2024
…p build workflow; previous commit: Add the edm4hep includes to allow compilation with clang (#166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Possible related discussion about different behavior for gcc and clang:
https://stackoverflow.com/questions/22770318/incomplete-types-in-template-code
With this change I can compile both on gcc and clang. Previously all the classes had to be specified anyway so having the includes is not that much of a change.