Make the event number 64 bits and unsigned (#398)

Co-authored-by: jmcarcell <[email protected]>
key4hep · Jan 31, 2025 · 5219b52 · 5219b52
1 parent ef9e4d6
commit 5219b52
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/edm4hep.yaml b/edm4hep.yaml
@@ -222,8 +222,8 @@ datatypes:
     Description: "Event Header. Additional parameters are assumed to go into the metadata tree."
     Author: "EDM4hep authors"
     Members:
-      - int32_t eventNumber    // event number
-      - int32_t runNumber      // run number
+      - uint64_t eventNumber    // event number
+      - uint32_t runNumber      // run number
       - uint64_t timeStamp     // time stamp
       - double weight       // event weight
     VectorMembers:

diff --git a/test/backwards_compat/CMakeLists.txt b/test/backwards_compat/CMakeLists.txt
@@ -10,12 +10,11 @@ set_tests_properties(
 )
 
 
-if (ROOT_VERSION VERSION_LESS 6.33)
-  # This input file has been written with RNTuple RC2 which is only present up
-  # to the 6.32 release series. Trying to read this with a newer version of ROOT
-  # doesn't work
+if (${ROOT_VERSION} VERSION_GREATER_EQUAL 6.34)
+  # This input file has been written with ROOT 6.34.
+  # Trying to read this with an older version of ROOT doesn't work
   ExternalData_Add_Test(backward_compat_tests
-    NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root})
+    NAME backwards_compat_rntuple_v00-99 COMMAND pytest -v --inputfile=DATA{${CMAKE_CURRENT_SOURCE_DIR}/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-02.root})
   set_test_env(backwards_compat_rntuple_v00-99)
 
   set_tests_properties(

diff --git a/test/backwards_compat/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root.md5 b/test/backwards_compat/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-01.root.md5
diff --git a/test/backwards_compat/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-02.root.md5 b/test/backwards_compat/input_files/edm4hep_example_rntuple_v00-99-01_podio_v01-02.root.md5
@@ -0,0 +1 @@
+ac7cf308fdec1685f968750429e4d243