fix: Don't wait for icon changes when spinning

Works around https://bugzilla.mozilla.org/show_bug.cgi?id=1911913
kewisch · Aug 10, 2024 · 717a7b5 · 717a7b5
1 parent d23946d
commit 717a7b5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "quickmove",
   "description": "Quick Folder Move",
-  "version": "2.9.0",
+  "version": "2.9.1",
   "private": true,
   "author": "Philipp Kewisch <[email protected]>",
   "license": "MPL-2.0",

diff --git a/src/background.js b/src/background.js
@@ -26,15 +26,15 @@ async function spinWith(func, ...args) {
   let rv;
   try {
     gSpinLevel++;
-    await browser.browserAction.setIcon({ path: "/images/spinner.svg" });
-    await browser.messageDisplayAction.setIcon({ path: "/images/spinner.svg" });
+    browser.browserAction.setIcon({ path: "/images/spinner.svg" });
+    browser.messageDisplayAction.setIcon({ path: "/images/spinner.svg" });
     rv = await func(...args);
   } finally {
     gSpinLevel--;
 
     if (gSpinLevel == 0) {
-      await browser.browserAction.setIcon({ path: "/images/addon.svg" });
-      await browser.messageDisplayAction.setIcon({ path: "/images/addon.svg" });
+      browser.browserAction.setIcon({ path: "/images/addon.svg" });
+      browser.messageDisplayAction.setIcon({ path: "/images/addon.svg" });
     }
   }
 

diff --git a/src/manifest.json b/src/manifest.json
@@ -2,14 +2,14 @@
   "manifest_version": 2,
   "name": "__MSG_extensionName__",
   "description": "__MSG_extensionDescription__",
-  "version": "2.9.0",
+  "version": "2.9.1",
   "default_locale": "en",
   "author": "Philipp Kewisch",
   "browser_specific_settings": {
     "gecko": {
       "id": "[email protected]",
       "strict_min_version": "115.0a1",
-      "strict_max_version": "128.*"
+      "strict_max_version": "129.*"
     }
   },
   "icons": {