Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Stale) WIP Enhance Observable pipe to handle concurrent events #311

Closed
wants to merge 1 commit into from
Closed

(Stale) WIP Enhance Observable pipe to handle concurrent events #311

wants to merge 1 commit into from

Conversation

kettanaito
Copy link
Owner

@kettanaito
Copy link
Owner Author

bufferTime can buffer patched fieldChange event very sufficiently.

There is an issue when handling manual field change (typing) with buffer. It appears that the fieldChange event from Field.componentWillReceiveProps doesn't fire correctly, and thus is not caught upon the initial buffering. Since it is being omitted, the field state is never updated.

I find this issue related to the usage of side-effects in componentWillReceiveProps, rather than event observables.

@kettanaito kettanaito changed the title WIP Enhancing Observable pipe to handle multiple change events WIP Enhance Observable pipe to handle concurrent events Oct 29, 2018
@kettanaito kettanaito force-pushed the 268-concurrent-state-updates branch from 67e77da to daed8a8 Compare November 4, 2018 17:24
@kettanaito kettanaito changed the title WIP Enhance Observable pipe to handle concurrent events (Stale) WIP Enhance Observable pipe to handle concurrent events Jan 17, 2019
@kettanaito kettanaito closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
possibly obsolete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kettanaito