Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KunMangaTo source #6192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add KunMangaTo source #6192

wants to merge 3 commits into from

Conversation

gtament
Copy link

@gtament gtament commented Nov 20, 2024

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

bapeey
bapeey reviewed Nov 20, 2024
View reviewed changes
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
src/en/kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaTo.kt Outdated Show resolved Hide resolved
.../kunmangato/src/eu/kanade/tachiyomi/extension/en/kunmangato/KunMangaToChapterResourcesDto.kt Outdated Show resolved Hide resolved
@gtament
Copy link
Author

gtament commented Nov 21, 2024 •
edited
Loading

@bapeey Pushed fixes in a separate commit. Will squash and force push in this branch after code's approval, if you don't mind (maybe I don't even need to be that specific of my actions)
Thanks for taking your time to review my code! I truly appreciate that
Also sorry for confusing you, by making several replies from another account (digis4eva)

@bapeey
Copy link
Contributor

bapeey commented Nov 21, 2024

All commits are squashed during the merge process, so don't worry about that

@vetleledaal vetleledaal marked this pull request as draft November 28, 2024 14:02
@github-actions github-actions bot added the Stale label Feb 1, 2025
@vetleledaal vetleledaal removed the Stale label Feb 1, 2025
@vetleledaal
Copy link
Contributor

Made the requested changes, it compiles. Unable to test since the site is down.

@vetleledaal vetleledaal marked this pull request as ready for review February 1, 2025 13:33
@vetleledaal vetleledaal added the Source is down The source website is closed and dead label Feb 1, 2025
@vetleledaal vetleledaal dismissed stale reviews from AwkwardPeak7 and themself February 1, 2025 13:33

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digis4eva digis4eva digis4eva left review comments

@bapeey bapeey bapeey left review comments

@vetleledaal vetleledaal vetleledaal left review comments

@AwkwardPeak7 AwkwardPeak7 AwkwardPeak7 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Source is down The source website is closed and dead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gtament @bapeey @vetleledaal @AwkwardPeak7 @digis4eva