Allow groups to restrict by browser integration key (#6437)

[ekimd]

Relates to issue #6437

This branch adds the ability to set a browser restriction on groups. This allows a given group tree to be visible only to a specific browser. Previously, the workaround was to have separate databases for each browser. However, this can become cumbersome under situations where someone may have a dozen or more browsers that each have to be unlocked whenever the screensaver activates.

Screenshots

Testing strategy

• Added a new test function to test the new behavior

Type of change

• ✅ New feature (change that adds functionality)

[ekimd]

@droidmonkey I don't understand the codecov/patch failure--what do I need to do to fix that?
Thanks

[droidmonkey]

We set an ideal threshold for new code introduced to be 75% covered by unit tests. It's optional though.

[ekimd]

Thanks. I tried increasing the test coverage but couldn't find a clear path given that some of the parent functions in BrowserService aren't tested.

How do I request a code review?

[varjolintu]

Could you solve the conflicts? Rebase the branch.

[ekimd]

Rebase complete

[varjolintu]

Some of the code could be cleaned a little bit. For example:

• Use QStringList instead if QList<QString> if possible.
• Use auto instead of QString when creating a new variable.
• Return {} instead of QString().
• If function parameter has a default value, use {} again.

[ekimd]

Thanks for the fast response!

I think I caught them all, but let me know if there's anything else. I couldn't return {} in BroswerService.cpp:996 because I got a compiler error returning an initializer list from that lambda function.

[varjolintu]

Tested this, and it works nicely. Only thing that caught my eye is the strange separator in the combobox:

When looking at other comboboxes, the separators look much more smaller:

[ekimd]

Interesting. I think that's because the screenshot above is actually referencing a QMenu not a ComboBox (see EditWidgetIcons.cpp:170).

[varjolintu]

Approved. We are missing a combobox separator style, but the scope is outside of this PR.

[ekimd]

Anything else I need to do to get approval on this?

[ekimd]

bump

[varjolintu]

bump

Bump? This PR is already accepted.

[ekimd]

Going to need some help here. There was a merge conflict so I resolved that but now one of the unit tests is failing and I'm not sure why. (It seems unrelated)

[droidmonkey]

You can ignore, we have sporadic failures since some tests rely on randomness and infrequently don't produce the expected results.

[ekimd]

Since I'm not familiar with the development cadence for this project, what is the typical timeline/workflow between approval, review, and merge?

[droidmonkey]

I will merge it in when I get the chance. Unfortunately my time is very limited lately.