Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim file path settings fields prior to save #11633

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

droidmonkey
Copy link
Member

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added the pr: bugfix Pull request that fixes a bug label Jan 6, 2025
@droidmonkey droidmonkey added this to the v2.7.10 milestone Jan 6, 2025
@droidmonkey droidmonkey requested a review from phoerious January 6, 2025 12:51
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.95%. Comparing base (17dc022) to head (6156400).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/sshagent/AgentSettingsWidget.cpp 0.00% 2 Missing ⚠️
src/browser/BrowserSettingsWidget.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11633      +/-   ##
===========================================
- Coverage    63.95%   63.95%   -0.00%     
===========================================
  Files          364      364              
  Lines        38309    38309              
===========================================
- Hits         24498    24497       -1     
- Misses       13811    13812       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path for SSH_AUTH_SOCK not trimmed for spaces
1 participant