Fix crash when pressing home key on empty tags field #11625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11625 +/- ##
===========================================
+ Coverage 63.93% 63.96% +0.03%
===========================================
Files 364 364
Lines 38307 38307
===========================================
+ Hits 24490 24501 +11
+ Misses 13817 13806 -11 ☔ View full report in Codecov by Sentry. |
phoerious
reviewed
Jan 4, 2025
droidmonkey
force-pushed
the
fix/tags-home-press
branch
from
4a187dd to
e24dff9
Compare
w15eacre
reviewed
Jan 7, 2025
phoerious
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Home/Endkeyboard keys in the tag field on Linux #11344Testing strategy
Pressing Home no longer produces crashes and all other functionality remains in tact.
Type of change