Detect outdated VC Redist with MSI Installer #11469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11469 +/- ##
===========================================
+ Coverage 63.84% 63.85% +0.01%
===========================================
Files 362 362
Lines 38115 38115
===========================================
+ Hits 24334 24336 +2
+ Misses 13781 13779 -2 ☔ View full report in Codecov by Sentry. |
|
Can you make it a clickable link? |
|
No, unfortunately not |
phoerious
approved these changes
Nov 16, 2024
|
At this point we should probably localise the installer, though. I bet many non-English users will have (even more) trouble with this message. |
|
Localizing MSI is nearly impossible, you have to provide a different MSI for each language you want to provide. It's just not worth it. https://wixtoolset.org/docs/v3/wixui/wixui_localization/#creating-multiple-setups-with-different-setup-ui-languages |
|
That's ridiculous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent installation of KeePassXC until the VC Redist is updated. Unfortunately, we cannot launch the web browser since you are only allowed to define one launch command and we use that to start KeePassXC post-install.
Testing strategy
Tested by reducing the version number in the registry.
Type of change