-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Proton Pass importer #11197
Add Proton Pass importer #11197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11197 +/- ##
===========================================
+ Coverage 63.88% 63.97% +0.09%
===========================================
Files 362 364 +2
Lines 38147 38277 +130
===========================================
+ Hits 24367 24486 +119
- Misses 13780 13791 +11 ☔ View full report in Codecov by Sentry. |
d909d9e
to
cb60486
Compare
cb60486
to
6bbf9d1
Compare
6bbf9d1
to
40f5c75
Compare
9704699
to
6dd6ce5
Compare
* Closes #10465
6dd6ce5
to
5cd9d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one request, but that's gonna be a little more work to fix.
Also maybe change the copyright header dates to 2025 already.
We will only support unencrypted json exports since Proton Pass uses PGP for encrypted exports for some reason.
We also do not support passkey exports from Proton Pass yet.
Screenshots
Testing strategy
Added unit tests
Type of change