Fix read-only preview

Refactor EntryAttachmentsWidget and PreviewEntryAttachmentsDialog to remove unnecessary parent references Fixes #11506
keepassxreboot · Jan 9, 2025 · 1c1483a · 1c1483a
1 parent e00aec9
commit 1c1483a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/gui/entry/EntryAttachmentsWidget.cpp b/src/gui/entry/EntryAttachmentsWidget.cpp
@@ -175,7 +175,7 @@ void EntryAttachmentsWidget::newAttachments()
         return;
     }
 
-    NewEntryAttachmentsDialog newEntryDialog{m_entryAttachments, this};
+    NewEntryAttachmentsDialog newEntryDialog{m_entryAttachments};
     if (newEntryDialog.exec() == QDialog::Accepted) {
         emit widgetUpdated();
     }
@@ -191,7 +191,7 @@ void EntryAttachmentsWidget::previewAttachments()
         return;
     }
 
-    PreviewEntryAttachmentsDialog previewDialog{m_entryAttachments, this};
+    PreviewEntryAttachmentsDialog previewDialog{m_entryAttachments};
     previewDialog.setAttachment(m_attachmentsModel->keyByIndex(index));
 
     previewDialog.exec();

diff --git a/src/gui/entry/PreviewEntryAttachmentsDialog.cpp b/src/gui/entry/PreviewEntryAttachmentsDialog.cpp
@@ -37,6 +37,7 @@ PreviewEntryAttachmentsDialog::PreviewEntryAttachmentsDialog(QPointer<EntryAttac
 
     m_ui->titleEdit->setReadOnly(true);
     m_ui->attachmentTextEdit->setReadOnly(true);
+    m_ui->errorLabel->setVisible(false);
 
     m_ui->dialogButtons->clear();
     m_ui->dialogButtons->addButton(QDialogButtonBox::Close);