-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
Added a Makefile allowing to generate Go bindings of given contracts.
Thoughts on keeping all of it in |
This change is motivated by the fact that `TBTCSystem` contract derives from `DepositLog` and it is the contract actually emitting deposit lifecycle events.
I know it's going to feel weird at first blush, but let's put these at the top level of the repo with a structure that matches what we're using elsewhere IMO. As in, |
Yeah, that's a very good idea. I guess we were thinking all the time that tbtc is Solidity-only and we were trying to reflect it in the directory structure by again, thinking that we are adding some Go but not that mutch. Nevertheless, it's no longer just a Solidity repository, and having the same structure everywhere is a good move. Especially that we already have Kube infrastructure files here. |
@pdyraga everything is addressed here. I'm ready for the next look! |
Refs: keep-network/keep-ecdsa#574
Depends on: keep-network/keep-common#52
Depends on: keep-network/keep-common#53
Added a
Makefile
allowing to generate Go bindings for given contracts using thego generate ./...
command. The solution is based on similar ones fromkeep-core
andkeep-ecdsa
projects. This PR also ships several ready to use bindings prepared using the aforementionedMakefile
.