This repository has been archived by the owner on May 22, 2023. It is now read-only.
Increase redemption fee by a step from the two latest events #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deposit requires the fee to be bumped by the constant value equal the initial redemption fee. To obtain the initial fee we looked for the very first event, we also need the latest event. It worked fine until there were multiple fee increases and the number of blocks to reach the first event exceeded 10k that is a default limitation for get past events. In such situation the first event that was returned wasn't actually the very first event registered on chain for the deposit. To overcome this issue we decided to calculate the initial fee as a delta between fees of the two latest events, as the step value is constant for each fee increase.
pdyraga
approved these changes
Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deposit requires the fee to be bumped by the constant value equal to the initial redemption fee.
To obtain the initial fee we looked for the very first event, we also need the latest event. It worked fine until there were multiple fee increases and the number of blocks to reach the first event exceeded 10k that is a default limitation for getPastEvents. In such situation, the first event that was returned wasn't actually the very first event registered on-chain for the deposit.
To overcome this issue we decided to calculate the initial fee as a delta between fees of the two latest events, as the step value is constant for each fee increase.
Refs: #574