Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Requiring group size and threshold to be > 0 #410

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

dimpar
Copy link
Contributor

@dimpar dimpar commented Apr 17, 2020

Refs: #392

It is not possible to create a group with 0 members. Similarly, it is not possible to create a group with 0 honest threshold. Added appropriate validations to openKeep contract functions.

@pdyraga pdyraga marked this pull request as ready for review April 17, 2020 21:33
@pdyraga
Copy link
Member

pdyraga commented Apr 17, 2020

@nkuba Is what we have here enough to close #392? Do we need to add a validation to the client to fail on 1-1 case and scenarios not currently supported by tss-lib?

@pdyraga
Copy link
Member

pdyraga commented Apr 17, 2020

Ah, alright. I see the second checkbox in the issue:

the client should check requested groupSize before starting the retry loop, log an error if group size < 2 (we will implement it proper way later in #408) and return.

Let's address it in a separate PR.

@nkuba nkuba merged commit 9e7c32d into master Apr 18, 2020
@nkuba nkuba deleted the group-size-and-threshold-validation branch April 18, 2020 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants