Cache swept deposits #3811
Merged
Cache swept deposits #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic always fetches swept deposits from the chain using Ethereum RPC server. This can be optimized. Swept deposits are final and no further changes occur regarding their state. That means swept deposits can be cached. This allows reducing network load and speeding up processed that needs to check a large number of deposits (e.g. deposit sweep and moving funds proposal generators). We use a time cache to evict unused keys over time and optimize memory consumption.
tomaszslabon
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic always fetches swept deposits from the chain using Ethereum RPC server. This can be optimized. Swept deposits are final and no further changes occur regarding their state. That means swept deposits can be cached. This allows reducing network load and speeding up processed that needs to check a large number of deposits (e.g. deposit sweep and moving funds proposal generators). We use a time cache to evict unused keys over time and optimize memory consumption.