RFC 12 Implementation: Integration with the on-chain proposal validator and final cleanup #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we re-generate tbtc contracts bindings in order to include the new `WalletProposalValidator` contract and remove the obsolete `WalletCoordinator`.
lukasz-zimnoch
changed the title
WalletProposalValidator and final cleanup
lukasz-zimnoch
changed the title
WalletProposalValidator and final cleanup
lukasz-zimnoch
changed the title
This is no longer needed with the new coordination mechanism. Proposals are now tied with specific wallet contexts so holding wallet PKH inside the proposal is redundant.
lukasz-zimnoch
force-pushed
the
rfc-12-impl-4
branch
from
f9fde70 to
c745fef
Compare
lukasz-zimnoch
force-pushed
the
rfc-12-impl-4
branch
from
c745fef to
19bc96b
Compare
lukasz-zimnoch
requested review from
tomaszslabon and
pdyraga
and removed request for
tomaszslabon
tomaszslabon
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/tbtc-v2#737
Here we present the sixth part of the changes meant to implement RFC 12: Decentralized wallet coordination in the tBTC wallet client. This pull request focuses on integrating with the new
WalletProposalValidatorcontract introduced in keep-network/tbtc-v2#756. It also aims to clean up all leftovers related to the old mechanism based on theWalletCoordinatorcontract.Use
WalletProposalValidatorfor on-chain proposal validationWe re-generated contract bindings to leverage the new WalletProposalValidator contract for on-chain proposal validation. Incoming deposit sweep, redemption, and heartbeat proposals are now validated against this contract, and we no longer use
WalletCoordinatorfor that purpose.Cleanup
WalletCoordinatorleftoversWe completely removed the
WalletCoordinatorcontract from the mix. The client no longer uses it in any way. This pull request's scope includes all necessary code cleanup and adjustments.Adjust SPV maintainer
The SPV maintainer was using recent proposals submitted to the
WalletCoordinatorcontract to determine a list of wallets that must be checked as part of the SPV proof submission process. AsWalletCoordinatoris no longer used, we modified that behavior. The SPV maintainer now examines recent deposit revealed and redemption requested events to build a list of wallets that likely have unproven transactions.Adjust maintainer deployment manifests
As wallet coordination was removed from the Keep maintainer bot, we adjusted Kubernetes manifests that are used to deploy the maintainer on production and test clusters. Now, only SPV and Bitcoin difficulty modules are in use.