-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use click features for project creation prompts #4387
Merged
Merged
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9bb3361
Test prompt change
lrcouto 10dbea5
Test adding default value
lrcouto 9b4a9a7
Change other prompts
lrcouto 73180ca
Move prompting logic to the inside of new function
lrcouto 48934d5
fix name default
lrcouto 3f184a8
Merge branch 'main' into click-validation-options
lrcouto 75456b7
Merge branch 'main' into click-validation-options
lrcouto 601b02f
Add auxiliary function for converting numbers to tools
lrcouto 8305cae
Merge branch 'main' into click-validation-options
lrcouto 05b7479
Merge branch 'main' into click-validation-options
lrcouto 7b71418
Normalize whitespaces in test outputs
lrcouto d0af3d3
Merge branch 'main' into click-validation-options
lrcouto 7aade5b
Merge branch 'main' into click-validation-options
lrcouto 0ce0219
Prevent prompts from happening when a config file is used
lrcouto 6d37aed
move click prompting to replace cookiecutter's
lrcouto 893415d
Remove reduntant variables
lrcouto f8cc6c3
Fix more tests
lrcouto c1e96df
All unit tests passing
lrcouto eae9d5a
Merge branch 'main' into click-validation-options
lrcouto 1d7af53
Revert unnecessary changes on tests
lrcouto 0ac3d2b
remove reduntant leftover code
lrcouto d8a6b6f
remove reduntant leftover code
lrcouto f9534ee
Set up prompt appearance
lrcouto f777d09
Revert default to unformatted
lrcouto da38e1a
Merge branch 'main' into click-validation-options
lrcouto 6cc3e15
Switch yes/no CLI prompts to click validation
lrcouto e71e015
Lint
lrcouto 5828415
Use click.Choice for telemetry, rest as our own function
lrcouto 0923ca4
Merge branch 'main' into click-validation-options
lrcouto 8eec43b
Change example validation back to what it was initially
lrcouto 20e5fe7
Merge branch 'main' into click-validation-options
lrcouto d821596
Revert verification to _Prompt.validate
lrcouto c4aec14
Merge branch 'click-validation-options' of github.com:kedro-org/kedro…
lrcouto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's clear enough now that this is doing validation 🤔 I have a slight preference to keeping the
validate()
method as before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, the other way is more explicit.