Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise modular pipelines docs #3948
Revise modular pipelines docs #3948
Changes from 19 commits
18a46ee
8a7d370
9fbf6b3
653dcde
53f94fe
8678eb7
23b0989
682efb1
c8e75a1
9ba96fc
7c93b58
bdae1ec
3d37b5c
c907c28
5999491
e235a24
7b06d9c
952c4fa
8fcc3c4
a58d31e
77ed3aa
4e2c8ac
faa08b2
84f444f
aa4a3c2
0ac37be
2fbf15e
0c14ce2
6b36ab9
bc04d86
c46dab3
1cfc4d7
cf63f67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 55 in docs/source/faq/faq.md
GitHub Actions / vale
[vale] docs/source/faq/faq.md#L55
Raw output
Check warning on line 56 in docs/source/faq/faq.md
GitHub Actions / vale
[vale] docs/source/faq/faq.md#L56
Raw output
Check warning on line 56 in docs/source/faq/faq.md
GitHub Actions / vale
[vale] docs/source/faq/faq.md#L56
Raw output
Large diffs are not rendered by default.
Check notice on line 5 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L5
Raw output
Check warning on line 5 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L5
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR overall uses less specific names than the current docs, which at least to me is an impact on docs quality. Compare:
create_new_pipeline
to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to
create_pipeline()
. If I understood correctly, the namecreate_pipeline()
is important (although it is not specific) because otherwise, the pipeline will not be autodiscovered and executed duringkedro new
(see Kedro documentation). If you see any other examples with less specific names, please let me know and I would be happy to fix them as well.Check warning on line 16 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L16
Raw output
Check warning on line 16 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L16
Raw output
Check warning on line 16 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L16
Raw output
Check warning on line 18 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L18
Raw output
Check warning on line 37 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L37
Raw output
Check warning on line 50 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L50
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thawed
is not present in the example at allThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to remove the cooking examples.
Check warning on line 93 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L93
Raw output
Check warning on line 95 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L95
Raw output
Check warning on line 97 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L97
Raw output
Check warning on line 97 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L97
Raw output
Check warning on line 98 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L98
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need both cooking and data science example to demonstrate how namespaces work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with that. We want to move away from the cooking example and shift to something more practical, based on our spaceflights-pandas starter. I previously kept the cooking example, but let's go ahead and remove it.
Check warning on line 123 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L123
Raw output
Check warning on line 125 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L125
Raw output
Check warning on line 155 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L155
Raw output
Check warning on line 155 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L155
Raw output
Check warning on line 164 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L164
Raw output
Check warning on line 172 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L172
Raw output
Check warning on line 172 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L172
Raw output
Check warning on line 172 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L172
Raw output
Check warning on line 212 in docs/source/nodes_and_pipelines/namespaces.md
GitHub Actions / vale
[vale] docs/source/nodes_and_pipelines/namespaces.md#L212
Raw output