Skip to content

Commit

Permalink
Add missing type annotations for wrapper functions
Browse files Browse the repository at this point in the history
Signed-off-by: Deepyaman Datta <[email protected]>
  • Loading branch information
deepyaman committed Jun 5, 2024
1 parent dfa9250 commit 25e5860
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions kedro/io/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ def _logger(self) -> logging.Logger:
return logging.getLogger(__name__)

@classmethod
def _load_wrapper(cls, load_func):
def _load_wrapper(cls, load_func: Callable[[], _DO]) -> Callable[[], _DO]:
@wraps(load_func)
def load(self):
def load(self) -> _DO:
self._logger.debug("Loading %s", str(self))

try:
Expand All @@ -196,13 +196,13 @@ def load(self):
raise DatasetError(message) from exc

load.__annotations__["return"] = load_func.__annotations__.get("return")
load.__loadwrapped__ = True
load.__loadwrapped__ = True # type: ignore[attr-defined]
return load

@classmethod
def _save_wrapper(cls, save_func):
def _save_wrapper(cls, save_func: Callable[[_DI], None]) -> Callable[[_DI], None]:
@wraps(save_func)
def save(self, data):
def save(self, data: _DI) -> None:
if data is None:
raise DatasetError("Saving 'None' to a 'Dataset' is not allowed")

Expand All @@ -219,24 +219,24 @@ def save(self, data):

save.__annotations__["data"] = save_func.__annotations__.get("data", Any)
save.__annotations__["return"] = save_func.__annotations__.get("return")
save.__savewrapped__ = True
save.__savewrapped__ = True # type: ignore[attr-defined]
return save

def __init_subclass__(cls, **kwargs) -> None:
def __init_subclass__(cls, **kwargs: Any) -> None:
super().__init_subclass__(**kwargs)

if hasattr(cls, "load") and not cls.load.__qualname__.startswith("Abstract"):
cls.load = cls._load_wrapper(
cls.load = cls._load_wrapper( # type: ignore[method-assign]
cls.load
if not getattr(cls.load, "__loadwrapped__", False)
else cls.load.__wrapped__
else cls.load.__wrapped__ # type: ignore[attr-defined]
)

if hasattr(cls, "save") and not cls.save.__qualname__.startswith("Abstract"):
cls.save = cls._save_wrapper(
cls.save = cls._save_wrapper( # type: ignore[method-assign]
cls.save
if not getattr(cls.save, "__savewrapped__", False)
else cls.save.__wrapped__
else cls.save.__wrapped__ # type: ignore[attr-defined]
)

def load(self) -> _DO:
Expand Down Expand Up @@ -678,9 +678,9 @@ def load(self) -> _DO:
return super().load()

@classmethod
def _save_wrapper(cls, save_func):
def _save_wrapper(cls, save_func: Callable[[_DI], None]) -> Callable[[_DI], None]:
@wraps(save_func)
def save(self, data):
def save(self, data: _DI) -> None:
self._version_cache.clear()
save_version = (
self.resolve_save_version()
Expand Down

0 comments on commit 25e5860

Please sign in to comment.