-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get version using restAPI #2242
Open
Huongg
wants to merge
12
commits into
feature_branch/remove-experiment-tracking
Choose a base branch
from
feature/remove-graphql
base: feature_branch/remove-experiment-tracking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
15ab3e8
set up rest for getversion
3dd6315
include get_latest_version, is_running_outdated_version
023965e
fixing the error
54f512c
remove graphql
2aae1dc
include test for getting version
5104506
remove check schema in lint
00bce4b
fix lint format error
90feefe
remove test for graphql
44117eb
fix syntax error
f3e7b13
remove apollo
09306f4
update libasound2 to libasound2t64 with the lates ubutun
55d98fc
update libgconf-2-4
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
"""`kedro_viz.api.rest.responses.version` contains response classes | ||
and utility functions for the `/version` REST endpoint""" | ||
|
||
from kedro_viz import __version__ | ||
from pydantic import BaseModel, ConfigDict | ||
from kedro_viz.api.rest.responses.base import BaseAPIResponse | ||
|
||
class VersionAPIResponse(BaseAPIResponse): | ||
""" | ||
VersionAPIResponse is a subclass of BaseAPIResponse that represents the response structure for version API. | ||
|
||
Attributes: | ||
installed (str): The installed version of the Kedro Viz package. | ||
isOutdated (bool): Whether the installed version is outdated. | ||
latest (str): The latest available version of the Kedro Viz package. | ||
""" | ||
|
||
installed: str | ||
isOutdated: bool | ||
latest: str | ||
model_config = ConfigDict( | ||
json_schema_extra={ | ||
"installed": __version__, | ||
"isOutdated": False, | ||
"latest": "0.5.0" # how do i check the latest version? | ||
} | ||
) | ||
|
||
def get_version_response(): | ||
"""API response for `/api/version`.""" | ||
installed_version = __version__ | ||
latest_version = "0.5.0" # how do i check the latest version? | ||
is_outdated = installed_version != latest_version | ||
|
||
return VersionAPIResponse( | ||
installed=installed_version, | ||
isOutdated=is_outdated, | ||
latest=latest_version | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from kedro_viz.integrations.pypi import get_latest_version, is_running_outdated_version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the same logic as we do in graphql
latest_version = get_latest_version()
is_outdated=is_running_outdated_version(installed_version, latest_version),