Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove et doc #2232

Merged
merged 15 commits into from
Jan 13, 2025
Merged

Feature/remove et doc #2232

merged 15 commits into from
Jan 13, 2025

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Jan 5, 2025 •
edited
Loading

Description

This PR is to address #2209. To remove the mentions of ET in our docs and read.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen added 12 commits December 5, 2024 11:33
revert back the getVersion in graphql
b4364d0 
Signed-off-by: Huong Nguyen <[email protected]>
update queries and schema
e8623f4 
Signed-off-by: Huong Nguyen <[email protected]>
fix lint error
7b55925 
Signed-off-by: Huong Nguyen <[email protected]>
Merge branch 'feature_branch/remove-experiment-tracking' into feature…
897194c 
…/remove-graphql-et
Merge branch 'feature_branch/remove-experiment-tracking' into feature…
a4e1d0e 
…/remove-graphql-et

Signed-off-by: Huong Nguyen <[email protected]>
revert graphql_router since it's still using in getVersion
6623712 
Signed-off-by: Huong Nguyen <[email protected]>
remove experiment-tracking.py, and runs and tracking datatset from repos
8b0aab0 
Signed-off-by: Huong Nguyen <[email protected]>
fix lint
e35ffae 
Signed-off-by: Huong Nguyen <[email protected]>
update format lint
f14800a 
Signed-off-by: Huong Nguyen <[email protected]>
remove set_database_session
43e8439 
Signed-off-by: Huong Nguyen <[email protected]>
remove ET mentioned in the doc and readme
30bc933 
Signed-off-by: Huong Nguyen <[email protected]>
remove ET and session store from readme
d85a67e 
Signed-off-by: Huong Nguyen <[email protected]>
Huong Nguyen added 2 commits January 5, 2025 21:30
ravi-kumar-pilla
ravi-kumar-pilla reviewed Jan 8, 2025
View reviewed changes
src/utils/index.js Outdated Show resolved Hide resolved
@ravi-kumar-pilla ravi-kumar-pilla self-requested a review January 9, 2025 17:22
ravi-kumar-pilla
ravi-kumar-pilla approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ... Thank you @Huongg

@Huongg Huongg merged commit d08dd12 into feature_branch/remove-experiment-tracking Jan 13, 2025
28 of 29 checks passed
@Huongg Huongg deleted the feature/remove-et-doc branch January 13, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-kumar-pilla ravi-kumar-pilla ravi-kumar-pilla approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@jitu5 jitu5 Awaiting requested review from jitu5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Huongg @rashidakanchwala @ravi-kumar-pilla