Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update lite banner #2196

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Feature/update lite banner #2196

merged 7 commits into from
Nov 20, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Nov 19, 2024

Description

Fixes #2128

To update the new icon and message for lite banner
Screenshot 2024-11-20 at 09 52 24

Final design :https://www.figma.com/design/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?node-id=2664-57397&node-type=instance&m=dev

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen added 2 commits November 19, 2024 12:29
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg Huongg requested a review from astrojuanlu as a code owner November 19, 2024 14:32
Huong Nguyen added 4 commits November 19, 2024 14:33
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg Huongg requested a review from stephkaiser November 20, 2024 09:59
Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jitu5 jitu5 mentioned this pull request Nov 20, 2024
5 tasks
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Huongg!

@Huongg Huongg merged commit dc5912d into main Nov 20, 2024
31 checks passed
@Huongg Huongg deleted the feature/update-lite-banner branch November 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kedro-viz lite banner icon
3 participants