Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Fix on --save-file functionality #2173

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Docs Fix on --save-file functionality #2173

merged 8 commits into from
Nov 5, 2024

Conversation

rashidakanchwala
Copy link
Contributor

Description

Resolves #1681

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@rashidakanchwala
done
e421528 
Signed-off-by: rashidakanchwala <[email protected]>
@rashidakanchwala rashidakanchwala marked this pull request as draft November 4, 2024 13:15
@rashidakanchwala rashidakanchwala marked this pull request as ready for review November 4, 2024 13:30
rashidakanchwala and others added 2 commits November 4, 2024 13:56
@rashidakanchwala @astrojuanlu
Update docs/source/kedro-viz_visualisation.md
8710aed 
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
@rashidakanchwala @astrojuanlu
Update docs/source/kedro-viz_visualisation.md
e51709c 
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
@rashidakanchwala rashidakanchwala marked this pull request as draft November 4, 2024 13:57
@rashidakanchwala rashidakanchwala marked this pull request as ready for review November 4, 2024 13:58
astrojuanlu
astrojuanlu approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rashidakanchwala rashidakanchwala merged commit 02331cc into main Nov 5, 2024
10 checks passed
@rashidakanchwala rashidakanchwala deleted the docs/save-file-clarity branch November 5, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitu5 jitu5 jitu5 approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify --save-file
3 participants
@rashidakanchwala @astrojuanlu @jitu5