Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HashRouter #2172

Closed
wants to merge 3 commits into from
Closed

Introduce HashRouter #2172

wants to merge 3 commits into from

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Nov 1, 2024

Description

Resolves #2048

This pull request includes changes to improve URL handling and routing in the application. The most important changes involve, switching from BrowserRouter to HashRouter and updating the pathname generation logic.

To fix the demo site issue, We need to move to hashRouter so now new url looks like this
https://jitu5.github.io/#/?types=nodes,datasets&pid=__default__&expandAllPipelines=false&sid=1e3cc50a

Accessing the experiment tracking page directly via the URL https://jitu5.github.io/#/experiment-tracking is working as expected.

The old URL without a # will work as expected, as a check has been added for redirection.
https://jitu5.github.io/?types=nodes,datasets&pid=__default__&expandAllPipelines=false&sid=1e3cc50a

Development notes

Improvements to URL handling:

Routing changes:

Pathname generation logic:

QA notes

I have deployed the changes to Github pages https://jitu5.github.io to test.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 self-assigned this Nov 1, 2024
@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Nov 1, 2024
@jitu5 jitu5 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Access to Experiment Tracking Causes 404 Error on viz demo
1 participant