Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2048
This pull request includes changes to improve URL handling and routing in the application. The most important changes involve, switching from
BrowserRouter
toHashRouter
and updating the pathname generation logic.To fix the demo site issue, We need to move to
hashRouter
so now new url looks like thishttps://jitu5.github.io/#/?types=nodes,datasets&pid=__default__&expandAllPipelines=false&sid=1e3cc50a
Accessing the experiment tracking page directly via the URL https://jitu5.github.io/#/experiment-tracking is working as expected.
The old URL without a
#
will work as expected, as a check has been added for redirection.https://jitu5.github.io/?types=nodes,datasets&pid=__default__&expandAllPipelines=false&sid=1e3cc50a
Development notes
Improvements to URL handling:
src/components/app/app.js
: Added logic to ensure the URL hash is correctly set when the component mounts.Routing changes:
src/components/wrapper/wrapper.js
: Switched fromBrowserRouter
toHashRouter
to handle routing with URL hashes.Pathname generation logic:
src/utils/hooks/use-generate-pathname.js
: Updated theuseGeneratePathname
hook to push the new URL only if it differs from the current URL.QA notes
I have deployed the changes to Github pages https://jitu5.github.io to test.Checklist
RELEASE.md
file