Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace watchgod library with watchfiles #2134

Merged
merged 29 commits into from
Nov 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint fix
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
jitu5 committed Oct 23, 2024
commit 19c6ef40278e7a78230f6c8dc2a6800729e0de6b
1 change: 1 addition & 0 deletions package/kedro_viz/autoreload_file_filter.py
Original file line number Diff line number Diff line change
@@ -75,6 +75,7 @@ def __call__(self, change: Change, path: str) -> bool:
):
logger.debug("Filtered out by .gitignore: %s", relative_path)
return False
# pylint: disable=broad-exception-caught
except Exception as exc:
logger.debug("Exception during .gitignore matching: %s", exc)
return True # Pass the file if .gitignore matching fails

Unchanged files with check annotations Beta

// sliced-pipeline-action-bar.test.js
import React from 'react';
import { render, screen } from '@testing-library/react';

Check warning on line 3 in src/components/sliced-pipeline-action-bar/sliced-pipeline-action-bar.test.js

GitHub Actions / javascript_lint_and_tests

'screen' is defined but never used
import { SlicedPipelineActionBar } from './sliced-pipeline-action-bar';
describe('SlicedPipelineActionBar', () => {
- Improve `kedro viz build` usage documentation (#2126)
- Fix unserializable parameters value (#2122)
- Replace `watchgod` library with `watchfiles` and improve autoreload file watching filter (#2134)

Check warning on line 19 in RELEASE.md

GitHub Actions / vale

[vale] RELEASE.md#L19

[Kedro-viz.Spellings] Did you really mean 'autoreload'?
Raw output
{"message": "[Kedro-viz.Spellings] Did you really mean 'autoreload'?", "location": {"path": "RELEASE.md", "range": {"start": {"line": 19, "column": 60}}}, "severity": "WARNING"}
- Display full dataset type with library prefix in metadata panel (#2136)
- Enable SQLite WAL mode for Azure ML to fix database locking issues (#2131)