-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc build fix: Demo site experiment tracking url updated #2051
Conversation
Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@ravi-kumar-pilla But build is still failing even after updating url with # https://readthedocs.org/projects/kedro-viz/builds/25384558/ |
Seems like the anchor link is still not found. May be we update this to https://demo.kedro.org/ for now |
Not sure if sphinx identifies the anchor link. If you type the link in browser, it does redirect to the homepage. Can you try adding homepage in package.json ? As of now it points to "." |
@ravi-kumar-pilla on browser it redirects to the homepage. but for now we can update this to https://demo.kedro.org/ |
Signed-off-by: Jitendra Gundaniya <[email protected]>
Description
Resolves #2050
After we moved demo site to Github pages, it doesn’t support routers that use the HTML5 pushState history API. So accessing the URL https://demo.kedro.org/experiment-tracking directly in the browser leads in 404.
This leads to broken build for the read the docs. https://readthedocs.org/projects/kedro-viz/builds/25360375/
Development notes
Checklist
RELEASE.md
file