Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc build fix: Demo site experiment tracking url updated #2051

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Aug 21, 2024

Description

Resolves #2050

After we moved demo site to Github pages, it doesn’t support routers that use the HTML5 pushState history API. So accessing the URL https://demo.kedro.org/experiment-tracking directly in the browser leads in 404.

This leads to broken build for the read the docs. https://readthedocs.org/projects/kedro-viz/builds/25360375/

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary fix and the original ticket #2050 should still be kept open after we merge this.

Thanks @jitu5

Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jitu5
Copy link
Contributor Author

jitu5 commented Aug 21, 2024

This is a temporary fix and the original ticket #2050 should still be kept open after we merge this.

Thanks @jitu5

@ravi-kumar-pilla But build is still failing even after updating url with # https://readthedocs.org/projects/kedro-viz/builds/25384558/

@ravi-kumar-pilla
Copy link
Contributor

Seems like the anchor link is still not found. May be we update this to https://demo.kedro.org/ for now
@rashidakanchwala ?

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Aug 21, 2024

This is a temporary fix and the original ticket #2050 should still be kept open after we merge this.
Thanks @jitu5

@ravi-kumar-pilla But build is still failing even after updating url with # https://readthedocs.org/projects/kedro-viz/builds/25384558/

Not sure if sphinx identifies the anchor link. If you type the link in browser, it does redirect to the homepage. Can you try adding homepage in package.json ? As of now it points to "."

@jitu5
Copy link
Contributor Author

jitu5 commented Aug 21, 2024

This is a temporary fix and the original ticket #2050 should still be kept open after we merge this.
Thanks @jitu5

@ravi-kumar-pilla But build is still failing even after updating url with # https://readthedocs.org/projects/kedro-viz/builds/25384558/

Not sure if sphinx identifies the anchor link. If you type the link in browser, it does redirect to the homepage. Can you try adding homepage in package.json ? As of now it points to "."

@ravi-kumar-pilla on browser it redirects to the homepage. but for now we can update this to https://demo.kedro.org/

Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 merged commit 5b091c3 into main Aug 21, 2024
10 checks passed
@jitu5 jitu5 deleted the fix/doc-build-fix-demo branch August 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GitHub Pages 404 on demo site routes
3 participants