-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable preview toggle in settings panel #1977
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
hey @SajidAlamQB what's the best way to test your branch locally? I run |
Hi, I'm making some changes at the moment, but I've been using |
oh i see, maybe i got it wrong but from the description it says when you run "kedro viz run". So i expect if i run "kedro viz run" the behaviour will be different from if i run "kedro viz build" etc. Is it the case? |
Signed-off-by: Sajid Alam <[email protected]>
It should be the same behaviour, I've made quite a few changes and updated the description might be worth testing again. |
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Thanks Sajid! some very minor design QA comments:
|
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @SajidAlamQB. I've left a few comments. Let me know if you have any questions about them
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @SajidAlamQB
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the PR comments @SajidAlamQB . LGTM and works well 💯
Description
Related to: #1921
This feature enables users to control data previews for all nodes from the settings panel of Kedro-Viz when running kedro viz locally.
After running Kedro-Viz locally, dataset previews for all nodes will be enabled by default. However, users will have the ability to enable or disable this feature from the Kedro-Viz settings panel.
Development Notes
Backend Changes:
/api/preferences
to handle user preferences updates.UserPreference
model to define the preference schema.router.py
to update theshowDatasetPreviews
preference and set the class variable accordingly.responses.py
to use the new preference for determining dataset preview settings.Frontend Changes:
showDatasetPreviews
toggle in the Redux state to manage the setting.SettingsModal
component to include theshowDatasetPreviews
toggle.How to Test:
New dataset preview toggle:
New API endpoint:
QA notes
Checklist
RELEASE.md
file