Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set isPrettyName to False by Default #1958

Merged
merged 36 commits into from
Jul 10, 2024
Merged

Set isPrettyName to False by Default #1958

merged 36 commits into from
Jul 10, 2024

Conversation

SajidAlamQB
Copy link
Contributor

Description

Related to: #1931

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB self-assigned this Jun 27, 2024
SajidAlamQB and others added 28 commits June 28, 2024 11:19
@SajidAlamQB
Merge branch 'main' into feat/toggle-pretty-name
7ea066f
@SajidAlamQB
debug
9f317c4 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update config.js
521ce9c 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update config.js
427b1cb 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update app.test.js
82f190b 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update app.test.js
16c7794 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
replace space with underscore
88220d1 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Merge branch 'main' into feat/toggle-pretty-name
70c91d3
@SajidAlamQB
fix tests when pretty name is off by default
78646a0 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
fix
3e5790f 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update index.js
c7db3a6 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
more fixes
27da800 
Signed-off-by: Sajid Alam <[email protected]>
fix some failed tests that are related to the prettyName is off by de…
111711c 
…fault

Signed-off-by: Huong Nguyen <huongg1409@gmail>
Add toLowerCase to some of the tests
59fb937 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@SajidAlamQB
Update app.test.js
bf56a30 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Merge branch 'main' into feat/toggle-pretty-name
411c475
@SajidAlamQB
add cypress custom command to enable pretty name
2ba111c 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update commands.js
655e6e0 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update commands.js
03fa1d1 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Update global-toolbar.cy.js
f4c529c 
Signed-off-by: Sajid Alam <[email protected]>
@jitu5
beforeEach for isPrettyName added
c72f70e 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5
menu test fix
f7c8a68 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@SajidAlamQB
Update experiment-tracking.cy.js
e68c625 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
attempt #2
dde465a 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
attempt 3
233ca75 
Signed-off-by: Sajid Alam <[email protected]>
@jitu5
Test fix
3c6a9d0 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@SajidAlamQB
Update experiment-tracking.cy.js
ec42c35 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
revert experiment tracking changes
d8c7666 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB SajidAlamQB marked this pull request as ready for review July 8, 2024 16:16
@SajidAlamQB SajidAlamQB requested a review from Huongg July 8, 2024 16:16
rashidakanchwala
rashidakanchwala approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @SajidAlamQB

jitu5
jitu5 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SajidAlamQB SajidAlamQB merged commit f8f0780 into main Jul 10, 2024
5 checks passed
@SajidAlamQB SajidAlamQB deleted the feat/toggle-pretty-name branch July 10, 2024 07:32
@SajidAlamQB SajidAlamQB mentioned this pull request Jul 10, 2024
Closed
1 task
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Jul 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@jitu5 jitu5 jitu5 approved these changes

@Huongg Huongg Awaiting requested review from Huongg

Assignees

@SajidAlamQB SajidAlamQB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SajidAlamQB @rashidakanchwala @jitu5