Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/9.1.0 #1919

Merged
merged 23 commits into from
May 30, 2024
Merged

Release/9.1.0 #1919

merged 23 commits into from
May 30, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented May 21, 2024

Description

Release 9.1.0

Major features and improvements

Bug fixes and other changes

Development note

  • I've included the title in the reminder-content panel (highlights panel), however I haven't come up with any great copy for those, will reach out to @stephkaiser for help on this
  • Also mentioned in the panelthe - Add support for JSONDataset preview. which was done from release 9.0.0

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huongg added 4 commits May 22, 2024 14:10
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
Huongg and others added 3 commits May 23, 2024 12:46
RELEASE.md Outdated Show resolved Hide resolved
@jitu5
Copy link
Contributor

jitu5 commented May 29, 2024

@Huongg If we are planing to release today, please update the release date here src/components/update-reminder/update-reminder-content.js

@rashidakanchwala rashidakanchwala self-requested a review May 29, 2024 08:16
Signed-off-by: huongg <[email protected]>
@Huongg Huongg requested review from stephkaiser and removed request for stephkaiser May 29, 2024 10:26
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

RELEASE.md Outdated Show resolved Hide resolved
@rashidakanchwala rashidakanchwala self-requested a review May 30, 2024 13:03
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :D

Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release

Co-authored-by: rashidakanchwala <[email protected]>
Signed-off-by: Huong Nguyen <[email protected]>
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
Signed-off-by: huongg <[email protected]>
@ravi-kumar-pilla
Copy link
Contributor

The below PRs are merged to main and they are internal. Should we mention them under ## other changes section for us to track ?

Fix build failure due to incompatible seaborn and matplotlib versions #1910
Update intersphinx_mapping of kedro-datasets #1911
Enable Gitpod in isRunningLocal #1923

Thank you

@Huongg
Copy link
Contributor Author

Huongg commented May 30, 2024

#1911

I'm not sure about #1911 but I remember #1923 and #1910 are not mentioned in the release note because they're only affecting us.

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented May 30, 2024

Good question, and I think this is also the part where we need to discuss in general, there's user facing changes, there's non-user facing but important dev cleanup/refactor that we shld ideally track when they were implemented, and then there are very minor non-user things that we don't put today. Ideally we want to balance out and not create too much noise for non-user related features, maybe as @stephkaiser suggested different headings.

for now, we can prolly include 1911, and in the future we can rethink this.

@ravi-kumar-pilla
Copy link
Contributor

#1911

#1910 - is mostly on demo_project which we use for testing (so can be ignored for now, but we can discuss in future where should these go)

#1911 and #1923 are changes in the source code of Kedro-Viz, so I feel we should track them ?

@Huongg
Copy link
Contributor Author

Huongg commented May 30, 2024

#1911

#1910 - is mostly on demo_project which we use for testing (so can be ignored for now, but we can discuss in future where should these go)

#1911 and #1923 are changes in the source code of Kedro-Viz, so I feel we should track them ?

I'm okay with including the 1923 👍

@ravi-kumar-pilla ravi-kumar-pilla self-requested a review May 30, 2024 15:49
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go!!

@ravi-kumar-pilla ravi-kumar-pilla merged commit 6881cb4 into main May 30, 2024
25 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the release/9.1.0 branch May 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants